From 9f76eea27202c1a8fb33afae0e6ceee3e9f60f37 Mon Sep 17 00:00:00 2001 From: Asger F Date: Wed, 25 Jun 2025 14:30:28 +0200 Subject: [PATCH] JS: Fix a bug in a unit test The 'extractTypeScriptFiles' override did not incorporate the file type and one of our unit tests was expecting this. The test was previously passing for the wrong reasons. --- .../semmle/js/extractor/test/AutoBuildTests.java | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/javascript/extractor/test/com/semmle/js/extractor/test/AutoBuildTests.java b/javascript/extractor/test/com/semmle/js/extractor/test/AutoBuildTests.java index 28c8e593dcd..5bbb0bb292e 100644 --- a/javascript/extractor/test/com/semmle/js/extractor/test/AutoBuildTests.java +++ b/javascript/extractor/test/com/semmle/js/extractor/test/AutoBuildTests.java @@ -111,12 +111,17 @@ public class AutoBuildTests { try { Set actual = new LinkedHashSet<>(); new AutoBuild() { + private void markExtracted(Path file, FileExtractor extractor) { + String extracted = file.toString(); + if (extractor.getConfig().hasFileType()) { + extracted += ":" + extractor.getFileType(file.toFile()); + } + actual.add(extracted); + } + @Override protected CompletableFuture extract(FileExtractor extractor, Path file, boolean concurrent) { - String extracted = file.toString(); - if (extractor.getConfig().hasFileType()) - extracted += ":" + extractor.getFileType(file.toFile()); - actual.add(extracted); + markExtracted(file, extractor); return CompletableFuture.completedFuture(null); } @@ -134,7 +139,7 @@ public class AutoBuildTests { java.util.Set extractedFiles, FileExtractors extractors) { for (Path f : files) { - actual.add(f.toString()); + markExtracted(f, extractors.forFile(f)); extractedFiles.add(f); } }