hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add spurious test case

Browse Source
This commit is contained in:
Tony Torralba
2021-06-28 12:16:41 +02:00
parent 19d1a780ca
commit 9e93aecf75
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
java/ql/test/query-tests/security/CWE-273/UnsafeCertTrustTest.java
View File

@@ -122,12 +122,23 @@ public class UnsafeCertTrustTest {
SSLSocket socket = (SSLSocket) socketFactory.createSocket();
if (safe) {
SSLParameters sslParameters = socket.getSSLParameters();
onSetSSLParameters(sslParameters);
sslParameters.setEndpointIdentificationAlgorithm("HTTPS");
socket.setSSLParameters(sslParameters);
}
socket.getOutputStream(); // Safe
}
public void testSSLSocketEndpointIdSafeWithSanitizerInCast(boolean safe) throws Exception {
SSLContext sslContext = SSLContext.getInstance("TLS");
SSLSocketFactory socketFactory = sslContext.getSocketFactory();
Socket socket = socketFactory.createSocket();
SSLSocket sslSocket = (SSLSocket) socket;
SSLParameters sslParameters = sslSocket.getSSLParameters();
sslParameters.setEndpointIdentificationAlgorithm("HTTPS");
sslSocket.setSSLParameters(sslParameters);
socket.getOutputStream(); // $ SPURIOUS: hasUnsafeCertTrust
}
public void testSocketEndpointIdNotSet() throws Exception {
SocketFactory socketFactory = SocketFactory.getDefault();
Socket socket = socketFactory.createSocket("www.example.com", 80);