hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: sharpen js/unneeded-defensive-code for negations and sequences

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2019-01-21 08:12:47 +01:00
parent cf3a4ac956
commit 9e4613094a
5 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/UnneededDefensiveProgramming.expected
View File

@@ -70,3 +70,5 @@
| tst.js:140:13:140:22 | x === null | This guard always evaluates to false. |
| tst.js:156:23:156:31 | x != null | This guard always evaluates to true. |
| tst.js:158:13:158:21 | x != null | This guard always evaluates to true. |
| tst.js:177:2:177:2 | u | This guard always evaluates to false. |
| tst.js:178:2:178:2 | u | This guard always evaluates to false. |

2
javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/UselessConditional.expected
View File

@@ -0,0 +1,2 @@
| tst.js:175:2:175:2 | u | This use of variable 'u' always evaluates to false. |
| tst.js:176:2:176:2 | u | This use of variable 'u' always evaluates to false. |

5
javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/tst.js
View File

@@ -171,4 +171,9 @@
if (typeof window !== "undefined" && window.document);
if (typeof module !== "undefined" && module.exports);
if (typeof global !== "undefined" && global.process);
u && (f(), u.p);
u && (u.p, f()); // technically not OK, but it seems like an unlikely pattern
u && !u.p; // NOT OK
u && !u(); // NOT OK
});