From 9e41f43ee2ccc67cfc811f1f28857e62f8cb7fea Mon Sep 17 00:00:00 2001 From: Daniel Santos Date: Fri, 17 Sep 2021 10:15:48 -0500 Subject: [PATCH] Fix: android.util.Log is final. No inheritance handling is needed. --- java/ql/src/experimental/semmle/code/java/Logging.qll | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/java/ql/src/experimental/semmle/code/java/Logging.qll b/java/ql/src/experimental/semmle/code/java/Logging.qll index 9d7efb1f330..7543e0514fc 100644 --- a/java/ql/src/experimental/semmle/code/java/Logging.qll +++ b/java/ql/src/experimental/semmle/code/java/Logging.qll @@ -29,13 +29,8 @@ class LoggingCall extends MethodAccess { ) or exists(RefType t, Method m | t.hasQualifiedName("android.util", "Log") | - ( - m.hasName(["d", "e", "i", "v", "w", "wtf"]) - ) and - ( - m.getDeclaringType().getASourceSupertype*() = t or - m.getDeclaringType().extendsOrImplements*(t) - ) and + m.hasName(["d", "e", "i", "v", "w", "wtf"]) and + m.getDeclaringType() = t and m.getReturnType() instanceof IntegralType and this = m.getAReference() )