hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 16:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update RegExp handling and add test case

Browse Source 
Co-authored-by: erik-krogh <erik-krogh@github.com>
This commit is contained in:
Napalys Klicius
2024-11-28 14:10:50 +01:00
committed by Napalys
parent fd773603e6
commit 9ca0fe4cbf
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/lib/semmle/javascript/security/dataflow/CleartextLoggingCustomizations.qll
View File

@@ -40,7 +40,7 @@ module CleartextLogging {
exists(this.getRawReplacement().getStringValue()) and
exists(DataFlow::RegExpCreationNode regexpObj |
this.(StringReplaceCall).getRegExp() = regexpObj and
regexpObj.getRoot() = any(RegExpDot term)
regexpObj.getRoot() = any(RegExpDot term).getRootTerm()
)
}
}

1
javascript/ql/test/query-tests/Security/CWE-312/passwords.js
View File

@@ -181,4 +181,5 @@ const debug = require('debug')('test');
console.log(password.replace(new RegExp(".", "g"), "*")); // OK
console.log(password.replace(new RegExp("."), "*")); // NOT OK
console.log(password.replace(new RegExp(".", unknownFlags()), "*")); // OK -- Most likely not a problem.
console.log(password.replace(new RegExp("pre_._suf", "g"), "*")); // OK
})();