hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

C#: Fix join-order in UselessUpcast.ql

Browse Source
This commit is contained in:
Tom Hvitved
2020-12-02 10:12:57 +01:00
parent 9dbcb7c642
commit 9c516bf62c
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
csharp/ql/src/Language Abuse/UselessUpcast.ql
View File

@@ -86,16 +86,21 @@ class ExplicitUpcast extends ExplicitCast {
src != dest // Handled by `cs/useless-cast-to-self` src != dest // Handled by `cs/useless-cast-to-self`
} }
/** Holds if this upcast is the argument of a call to `target`. */ pragma[nomagic]
private predicate isArgument(Call c, Callable target) { private predicate isArgument(Type t) {
exists(Parameter p | exists(Parameter p |
this = p.getAnAssignedArgument() and this = p.getAnAssignedArgument() and
p.getType() = this.getType() and t = p.getType()
c.getAnArgument() = this and
target = c.getTarget()
) )
} }
/** Holds if this upcast is the argument of a call to `target`. */
private predicate isArgument(Call c, Callable target) {
this.isArgument(this.getType()) and
c.getAnArgument() = this and
target = c.getTarget()
}
/** Holds if this upcast may be used to disambiguate the target of an instance call. */ /** Holds if this upcast may be used to disambiguate the target of an instance call. */
pragma[nomagic] pragma[nomagic]
private predicate isDisambiguatingInstanceCall(InstanceCallable other, int args) { private predicate isDisambiguatingInstanceCall(InstanceCallable other, int args) {