renamed "forinscope" to "for_in_scope"

javascript/ql/src/semmle/javascript/Variables.qll

@@ -94,7 +94,7 @@ class ForScope extends Scope, @for_scope {
 }
 
 /** A scope induced by a `for`-`in` or `for`-`of` statement. */
-class ForInScope extends Scope, @forinscope {
+class ForInScope extends Scope, @for_in_scope {
   /** Gets the `for`-`in` or `for`-`of` statement that induces this scope. */
   EnhancedForLoop getLoop() { result = getScopeElement() }
 

javascript/ql/src/semmlecode.javascript.dbscheme

@@ -415,7 +415,7 @@ case @scope.kind of
 |  3 = @module_scope
 |  4 = @block_scope
 |  5 = @for_scope
-|  6 = @forinscope // for-of scopes work the same as for-in scopes
+|  6 = @for_in_scope // for-of scopes work the same as for-in scopes
 |  7 = @comprehensionblockscope
 |  8 = @classexprscope
 |  9 = @namespacescope

javascript/ql/src/semmlecode.javascript.dbscheme.stats

@@ -658,7 +658,7 @@
 <v>17</v>
 </e>
 <e>
-<k>@forinscope</k>
+<k>@for_in_scope</k>
 <v>28</v>
 </e>
 <e>