hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Update OK-style comments to $-style

Browse Source
This commit is contained in:
Asger F
2025-02-06 13:34:01 +01:00
parent 7e5c24a8ec
commit 9be041e27d
536 changed files with 4408 additions and 4762 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
javascript/ql/test/query-tests/React/InconsistentStateUpdate/tst.js
View File

@@ -1,7 +1,7 @@
class C1 extends React.Component {
upd8() {
this.setState({
counter: this.state.counter + 1 // NOT OK, but ignored because it is safe in practice
counter: this.state.counter + 1 // OK - ignored because it is safe in practice
});
}
}
@@ -9,7 +9,7 @@ class C1 extends React.Component {
class C2 extends React.Component {
upd8() {
this.setState((prevState) => {
counter: prevState.counter + 1 // OK
counter: prevState.counter + 1
});
}
}
@@ -18,7 +18,7 @@ class C3 extends React.Component {
upd8() {
var app = this;
app.setState({
counter: this.state.counter + 1 // NOT OK, but ignored because it is safe in practice
counter: this.state.counter + 1 // OK - ignored because it is safe in practice
});
}
}
@@ -26,7 +26,7 @@ class C3 extends React.Component {
class C4 extends React.Component {
upd8() {
this.setState({
counter: this.state.foo // NOT OK
counter: this.state.foo // $ Alert
});
}
}
@@ -34,7 +34,7 @@ class C4 extends React.Component {
class C5 extends React.Component {
upd8() {
this.setState({
foo: { bar: this.state.foo.bar } // NOT OK
foo: { bar: this.state.foo.bar } // $ Alert
});
}
}
@@ -42,13 +42,13 @@ class C5 extends React.Component {
class C7 extends React.Component {
upd8a() {
this.setState({
foo: this.state.foo // NOT OK
foo: this.state.foo // $ Alert
});
}
upd8b() {
this.setState({
foo: this.state.foo // NOT OK
foo: this.state.foo // $ Alert
});
}
}
@@ -56,13 +56,13 @@ class C7 extends React.Component {
class C8 extends React.Component {
upd8a() {
this.setState({
foo: this.state.foo + 1 // NOT OK
foo: this.state.foo + 1 // $ Alert
});
}
upd8b() {
this.setState({
foo: this.state.foo + 1 // NOT OK
foo: this.state.foo + 1 // $ Alert
});
}
}
@@ -70,13 +70,13 @@ class C8 extends React.Component {
class C9 extends React.Component {
upd8a() {
this.setState({
foo: { bar: this.state.foo.bar } // NOT OK
foo: { bar: this.state.foo.bar } // $ Alert
});
}
upd8b() {
this.setState({
foo: { bar: this.state.foo.bar } // NOT OK
foo: { bar: this.state.foo.bar } // $ Alert
});
}
}
@@ -84,14 +84,14 @@ class C9 extends React.Component {
class C10 extends React.Component {
upd8a() {
this.setState({
foo: this.state.foo, // NOT OK
bar: this.state.bar // NOT OK, but ignored because it is safe in practice
foo: this.state.foo, // $ Alert
});
bar: this.state.bar // OK - ignored because it is safe in practice
}
upd8b() {
this.setState({
foo: this.state.foo // NOT OK
foo: this.state.foo // $ Alert
});
}
}
@@ -100,13 +100,13 @@ class C11 extends React.Component {
upd8a() {
var self = this;
self.setState({
foo: self.state.foo // NOT OK
foo: self.state.foo // $ Alert
});
}
upd8b() {
this.setState({
foo: this.state.foo // NOT OK
foo: this.state.foo // $ Alert
});
}
}