mirror of
https://github.com/github/codeql.git
synced 2026-05-02 04:05:14 +02:00
JS: Update OK-style comments to $-style
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
const {BrowserWindow} = require('electron')
|
||||
|
||||
function test() {
|
||||
var unsafe_1 = { // NOT OK, both enabled
|
||||
var unsafe_1 = { // $ Alert - both enabled
|
||||
webPreferences: {
|
||||
nodeIntegration: true,
|
||||
nodeIntegrationInWorker: true,
|
||||
@@ -11,7 +11,7 @@ function test() {
|
||||
}
|
||||
};
|
||||
|
||||
var options_1 = { // NOT OK, `nodeIntegrationInWorker` enabled
|
||||
var options_1 = { // $ Alert - `nodeIntegrationInWorker` enabled
|
||||
webPreferences: {
|
||||
plugins: true,
|
||||
nodeIntegrationInWorker: false,
|
||||
@@ -20,13 +20,13 @@ function test() {
|
||||
}
|
||||
};
|
||||
|
||||
var pref = { // NOT OK, implicitly enabled
|
||||
var pref = { // $ Alert - implicitly enabled
|
||||
plugins: true,
|
||||
webSecurity: true,
|
||||
sandbox: true
|
||||
};
|
||||
|
||||
var options_2 = { // NOT OK, implicitly enabled
|
||||
var options_2 = { // $ Alert - implicitly enabled
|
||||
webPreferences: pref,
|
||||
show: true,
|
||||
frame: true,
|
||||
@@ -34,7 +34,7 @@ function test() {
|
||||
minHeight: 300
|
||||
};
|
||||
|
||||
var safe_used = { // NOT OK, explicitly disabled
|
||||
var safe_used = { // $ Alert - explicitly disabled
|
||||
webPreferences: {
|
||||
nodeIntegration: false,
|
||||
plugins: true,
|
||||
@@ -46,7 +46,7 @@ function test() {
|
||||
var w1 = new BrowserWindow(unsafe_1);
|
||||
var w2 = new BrowserWindow(options_1);
|
||||
var w3 = new BrowserWindow(safe_used);
|
||||
var w4 = new BrowserWindow({width: 800, height: 600, webPreferences: {nodeIntegration: true}}); // NOT OK, `nodeIntegration` enabled
|
||||
var w4 = new BrowserWindow({width: 800, height: 600, webPreferences: {nodeIntegration: true}}); // $ Alert - `nodeIntegration` enabled
|
||||
var w5 = new BrowserWindow(options_2);
|
||||
var w6 = new BrowserWindow(safe_used);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user