JS: Update OK-style comments to $-style

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/computedFieldNames.ts

@@ -1,11 +1,11 @@
 import dummy from 'dummy';
 
-var key1 = "key1"; // OK
+var key1 = "key1";
 export class NoConstructor {
   [key1] = 4;
 }
 
-var key2 = "key2"; // OK
+var key2 = "key2";
 export class WithConstructor {
   [key2] = 4;
 

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/computedInterfaceProperty.ts

@@ -1,16 +1,16 @@
-import { Foo } from "./exportSymbol" // OK
+import { Foo } from "./exportSymbol"
 
 export interface FooMap {
-  [Foo]: number; // OK
+  [Foo]: number;
 }
 
-const Bar = "Bar"; // OK
+const Bar = "Bar";
 
 export interface BarMap {
   [Bar]: number;
 }
 
-const Baz = "Baz"; // OK
+const Baz = "Baz";
 
 if (false) {
   Baz;
@@ -18,7 +18,7 @@ if (false) {
 
 function getBaz(): typeof Baz { return null; }
 
-class C {} // OK
+class C {}
 
 if (false) {
   C;

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/exportDefaultClass.ts

@@ -1,5 +1,5 @@
-var C1 = global.C1; // OK
-var C2 = global.C2; // OK
+var C1 = global.C1;
+var C2 = global.C2;
 
 class C extends C1 {}
 export default class extends C2 {}

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/exportDefaultFunction.ts

@@ -1,3 +1,3 @@
-var C1 = global.C1; // OK
+var C1 = global.C1;
 
 export default function(x=C1) {}

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/extends.js

@@ -1,4 +1,4 @@
-const React = require('react'); // OK: used in `extends` clause below
+const React = require('react'); // OK - used in `extends` clause below
 
 class Foo extends React.Component {
 }

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/for-of-continue.js

@@ -2,7 +2,7 @@ function f() {
   let y = false;
   for (const x of [1, 2, 3]) {
     if (x > 0) {
-        y = true; // OK
+        y = true;
         continue;
     }
     return;

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/namespace.ts

@@ -9,5 +9,5 @@ namespace a.b.q {
 
   registerSomething(c);
 
-  function foo() {} // OK
+  function foo() {}
 }

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/overload.ts

@@ -1,13 +1,13 @@
 export function foo() {
-  function bar(x: number): number; // OK
-  function bar(x: string): string; // OK
-  function bar(x: any) { // OK
+  function bar(x: number): number;
+  function bar(x: string): string;
+  function bar(x: any) {
     return x;
   }
   
-  function baz(x: number): number; // OK
-  function baz(x: string): string; // OK
-  function baz(x: any) { // NOT OK, overwritten before use
+  function baz(x: number): number;
+  function baz(x: string): string;
+  function baz(x: any) { // $ Alert - overwritten before use
     return x;
   }
   baz = (x) => x;

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst.js

@@ -1,17 +1,15 @@
 function f() {
-	// OK: initialization to default value
+	// OK - initialization to default value
 	var x = null, y = undefined, z;
 	x = {};
-	// NOT OK
-	y = 23;
+	y = 23; // $ Alert
 	y = 42;
 	for (var p in x)
 		y+p;
-	// OK: assignment to global
+	// OK - assignment to global
 	global = 42;
-	// NOT OK
-	var a = 23; a = 42;
-	// OK: captured variable
+	var a = 23; a = 42; // $ Alert
+	// OK - captured variable
 	var b = 42;
 	return function() {
 		return b%2
@@ -20,14 +18,14 @@ function f() {
 
 function g() {
 	var x;
-	// OK
+
 	x = 23, x += 19;
-	// OK
+
 	var y = 42;
 }
 
 function h() {
-	// OK
+
 	var x = false;
 	try {
 		this.mayThrow();
@@ -37,7 +35,7 @@ function h() {
 }
 
 function k(data) {
-	// OK
+
 	for(var i=0;i<data.length;i++);
 }
 
@@ -62,7 +60,7 @@ function p() {
 	var i;
 	for (i=0; i < 10; ++i) {
 		if (Math.random() > .5)
-			// OK
+
 			i = 23;
 	}
 }
@@ -87,11 +85,11 @@ function s() {
     var container = document.createElement("div"),
         div = document.createElement("div");
     doStuffWith(container, div);
-    // OK
+
     container = div = null;
 }
 
-// OK: the function expression could be made anonymous, but it's not
+// OK - the function expression could be made anonymous, but it's not
 // worth flagging this as a violation
 defineGetter(req, 'subdomains', function subdomains() {
     var hostname = this.hostname;
@@ -103,7 +101,7 @@ defineGetter(req, 'subdomains', function subdomains() {
     return subdomains.slice(offset);
 });
 
-// OK: assigning default values
+// OK - assigning default values
 function t() {
   var x;
   x = false;
@@ -112,7 +110,7 @@ function t() {
   x = 42; return x;
 }
 
-// OK: unnecessary initialisation as type hint
+// OK - unnecessary initialisation as type hint
 function u() {
   var x;
   x = [];
@@ -120,7 +118,7 @@ function u() {
   x = 42; return x;
 }
 
-// OK: assigning `undefined`
+// OK - assigning `undefined`
 function v() {
   var x;
   x = void 0;
@@ -134,7 +132,7 @@ function v() {
   return x;
 }
 
-// OK: assignments in dead code not flagged
+// OK - assignments in dead code not flagged
 !function() {
   return;
   var x;
@@ -159,7 +157,7 @@ function v() {
 });
 
 (function() {
-	let [x] = [0], // OK, but flagged due to destructuring limitations
+	let [x] = [0], // $ SPURIOUS: Alert - flagged due to destructuring limitations
 	    y = 0;
 	x = 42;
 	y = 87;

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst2.js

@@ -1,5 +1,5 @@
 function outer(b) {
-    // OK
+
     let addSubdomain = false;
 
     if (x) {
@@ -16,14 +16,13 @@ function outer(b) {
 }
 
 function f(event) {
-    // OK
+
     var message = event.data;
     eme.init().then(() => NativeInfo.processApp('install', message.id));
 }
 
 function g() {
-    // NOT OK
-    let x = 23;
+    let x = 23; // $ Alert
     {
         x = 42;
     }

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst3.js

@@ -1,2 +1 @@
-// NOT OK
-exports = module.exports = { a: 23 };
+exports = module.exports = { a: 23 }; // $ Alert

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst3b.js

@@ -1,2 +1 @@
-// NOT OK
-module.exports = exports = { a: 23 };
+module.exports = exports = { a: 23 }; // $ Alert