From 9b9c19b76c73c4c8470bccaa79ac4cf74a0023d5 Mon Sep 17 00:00:00 2001 From: Esben Sparre Andreasen Date: Tue, 27 Oct 2020 22:07:57 +0100 Subject: [PATCH] Remove additional Xss sinks --- javascript/ql/lib/semmle/javascript/DOM.qll | 5 ----- javascript/ql/lib/semmle/javascript/frameworks/jQuery.qll | 2 -- 2 files changed, 7 deletions(-) diff --git a/javascript/ql/lib/semmle/javascript/DOM.qll b/javascript/ql/lib/semmle/javascript/DOM.qll index 70ee5e45daf..a87fb21ccbd 100644 --- a/javascript/ql/lib/semmle/javascript/DOM.qll +++ b/javascript/ql/lib/semmle/javascript/DOM.qll @@ -387,11 +387,6 @@ module DOM { or t.start() and result = domValueRef().getAMethodCall(["item", "namedItem"]) - or - t.startInProp("target") and - result = domEventSource() - or - exists(DataFlow::TypeTracker t2 | result = domValueRef(t2).track(t2, t)) } /** Gets a data flow node that may refer to a value from the DOM. */ diff --git a/javascript/ql/lib/semmle/javascript/frameworks/jQuery.qll b/javascript/ql/lib/semmle/javascript/frameworks/jQuery.qll index e65f6d70dcf..a9fdd7b03c0 100644 --- a/javascript/ql/lib/semmle/javascript/frameworks/jQuery.qll +++ b/javascript/ql/lib/semmle/javascript/frameworks/jQuery.qll @@ -428,8 +428,6 @@ module JQuery { private DataFlow::SourceNode dollar(DataFlow::TypeTracker t) { t.start() and result = dollarSource() - or - exists(DataFlow::TypeTracker t2 | result = dollar(t2).track(t2, t)) } /**