mirror of
https://github.com/github/codeql.git
synced 2026-04-30 11:15:13 +02:00
Apply suggestions from code review
Co-authored-by: Chris Smowton <smowton@github.com>
This commit is contained in:
committed by
Fosstars
parent
ad54c9d937
commit
9b953cf0fc
@@ -238,7 +238,7 @@ private predicate looksLikeConstant(Expr expr) {
|
||||
* Holds if `firstObject` and `secondObject` are compared using a method
|
||||
* that does not use a constant-time algorithm, for example, `String.equals()`.
|
||||
*/
|
||||
private predicate isNonConstantEqualsCall(Expr firstObject, Expr secondObject) {
|
||||
private predicate isNonConstantTimeEqualsCall(Expr firstObject, Expr secondObject) {
|
||||
exists(NonConstantTimeEqualsCall call |
|
||||
firstObject = call.getQualifier() and
|
||||
secondObject = call.getAnArgument()
|
||||
|
||||
@@ -257,7 +257,6 @@ private predicate sinkModelCsv(string row) {
|
||||
]
|
||||
}
|
||||
|
||||
// TODO: add ByteBuffer
|
||||
private predicate summaryModelCsv(string row) {
|
||||
row =
|
||||
[
|
||||
|
||||
Reference in New Issue
Block a user