hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Move ExternallyControlledFormatStringFlow to Query.qll

Browse Source
This commit is contained in:
Ed Minnix
2023-03-29 14:51:27 -04:00
parent 7d9fad5733
commit 9afa051621
2 changed files with 27 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
java/ql/lib/semmle/code/java/security/ExternallyControlledFormatStringQuery.qll Normal file
View File

@@ -0,0 +1,26 @@
/** Provides a taint-tracking configuration to reason about externally controlled format string vulnerabilities. */
import java
import semmle.code.java.dataflow.FlowSources
import semmle.code.java.StringFormat
/**
* A taint-tracking configuration for externally controlled format string vulnerabilities.
*/
module ExternallyControlledFormatStringConfig implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
predicate isSink(DataFlow::Node sink) {
sink.asExpr() = any(StringFormat formatCall).getFormatArgument()
}
predicate isBarrier(DataFlow::Node node) {
node.getType() instanceof NumericType or node.getType() instanceof BooleanType
}
}
/**
* Taint-tracking flow for externally controlled format string vulnerabilities.
*/
module ExternallyControlledFormatStringFlow =
TaintTracking::Global<ExternallyControlledFormatStringConfig>;

19
java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatString.ql
View File

@@ -11,24 +11,7 @@
*/
import java
import semmle.code.java.dataflow.FlowSources
import semmle.code.java.StringFormat
module ExternallyControlledFormatStringConfig implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
predicate isSink(DataFlow::Node sink) {
sink.asExpr() = any(StringFormat formatCall).getFormatArgument()
}
predicate isBarrier(DataFlow::Node node) {
node.getType() instanceof NumericType or node.getType() instanceof BooleanType
}
}
module ExternallyControlledFormatStringFlow =
TaintTracking::Global<ExternallyControlledFormatStringConfig>;
import semmle.code.java.security.ExternallyControlledFormatStringQuery
import ExternallyControlledFormatStringFlow::PathGraph
from