hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: update to only find 'finalize' calls and add 'super.finalize' exclusion

Browse Source
This commit is contained in:
Jami Cogswell
2025-03-20 08:58:48 -04:00
parent 56ea9b6523
commit 9a6e241f54
10 changed files with 65 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/ql/test/query-tests/DoNotUseFinalize/DoNotUseFinalize.expected Normal file
View File

@@ -0,0 +1 @@
| Test.java:3:9:3:23 | finalize(...) | Call to 'finalize'. |

1
java/ql/test/query-tests/DoNotUseFinalize/DoNotUseFinalize.qlref Normal file
View File

@@ -0,0 +1 @@
Violations of Best Practice/Undesirable Calls/DoNotUseFinalize.ql

9
java/ql/test/query-tests/DoNotUseFinalize/Test.java Normal file
View File

@@ -0,0 +1,9 @@
public class Test {
void f() throws Throwable {
this.finalize(); // NON_COMPLIANT
}
void f1() throws Throwable {
f(); // COMPLIANT
}
}

3
java/ql/test/query-tests/DoNotUseFinalizers/DoNotUseFinalizers.expected
View File

@@ -1,3 +0,0 @@
| Test.java:3:9:3:19 | gc(...) | Call to prohibited method that may modify the JVM's garbage collection process. |
| Test.java:4:9:4:33 | gc(...) | Call to prohibited method that may modify the JVM's garbage collection process. |
| Test.java:5:9:5:23 | finalize(...) | Call to prohibited method that may modify the JVM's garbage collection process. |

1
java/ql/test/query-tests/DoNotUseFinalizers/DoNotUseFinalizers.qlref
View File

@@ -1 +0,0 @@
rules/J-FIN-002/DoNotUseFinalizers.ql

13
java/ql/test/query-tests/DoNotUseFinalizers/Test.java
View File

@@ -1,13 +0,0 @@
public class Test {
void f() throws Throwable {
System.gc(); // NON_COMPLIANT
Runtime.getRuntime().gc(); // NON_COMPLIANT
this.finalize(); // NON_COMPLIANT
// this is removed in Java 11
//System.runFinalizersOnExit(true); // NON_COMPLIANT
}
void f1() throws Throwable {
f(); // COMPLIANT
}
}