Merge pull request #1025 from xiemaisi/js/fix-exports-assign

Approved by asger-semmle

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/DeadStoreOfLocal.expected

@@ -1,6 +1,8 @@
 | overload.ts:10:12:10:14 | baz | This definition of baz is useless, since its value is never read. |
 | tst2.js:26:9:26:14 | x = 23 | This definition of x is useless, since its value is never read. |
 | tst2.js:28:9:28:14 | x = 42 | This definition of x is useless, since its value is never read. |
+| tst3.js:2:1:2:36 | exports ... a: 23 } | This definition of exports is useless, since its value is never read. |
+| tst3b.js:2:18:2:36 | exports = { a: 23 } | This definition of exports is useless, since its value is never read. |
 | tst.js:6:2:6:7 | y = 23 | This definition of y is useless, since its value is never read. |
 | tst.js:13:6:13:11 | a = 23 | This definition of a is useless, since its value is never read. |
 | tst.js:13:14:13:19 | a = 42 | This definition of a is useless, since its value is never read. |

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst3.js

@@ -0,0 +1,2 @@
+// NOT OK
+exports = module.exports = { a: 23 };

javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst3b.js

@@ -0,0 +1,2 @@
+// NOT OK
+module.exports = exports = { a: 23 };

javascript/ql/test/query-tests/NodeJS/InvalidExport/InvalidExport.expected

@@ -1,3 +1,2 @@
-| tst3.js:2:1:2:36 | exports ... a: 23 } | Assigning to 'exports' does not export anything. |
 | tst5.js:3:1:3:12 | exports = {} | Assigning to 'exports' does not export anything. |
 | tst.js:2:1:2:12 | exports = 56 | Assigning to 'exports' does not export anything. |

javascript/ql/test/query-tests/NodeJS/InvalidExport/tst3.js

@@ -1,2 +1,2 @@
-// NOT OK: useless assignment
+// OK: useless assignment flagged by other query
 exports = module.exports = { a: 23 };

javascript/ql/test/query-tests/NodeJS/InvalidExport/tst3b.js

@@ -0,0 +1,2 @@
+// OK: useless assignment flagged by other query
+module.exports = exports = { a: 23 };