hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: Fix bug in ConstantExpAppearsNonConstant.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2025-10-08 10:32:51 +02:00
parent 28fe20e3e4
commit 99f5dcaaa4
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
View File

@@ -19,7 +19,7 @@ predicate isConstantExp(Expr e) {
// A literal is constant. // A literal is constant.
e instanceof Literal e instanceof Literal
or or
e instanceof TypeAccess and not e.(TypeAccess).getType() instanceof ErrorType e instanceof TypeAccess
or or
e instanceof ArrayTypeAccess e instanceof ArrayTypeAccess
or or
@@ -53,6 +53,7 @@ predicate isConstantExp(Expr e) {
from Expr e from Expr e
where where
isConstantExp(e) and isConstantExp(e) and
not e.(TypeAccess).getType() instanceof ErrorType and
exists(Expr child | e.getAChildExpr() = child | exists(Expr child | e.getAChildExpr() = child |
not isConstantExp(child) and not isConstantExp(child) and
not child instanceof Annotation not child instanceof Annotation