hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Add a comment to the 'ConditionalBranchInstruction' case in 'additionalImpliesStep.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2025-09-24 10:58:47 +01:00
parent 2b47ac83e8
commit 99e1a07b8e
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll
View File

@@ -434,6 +434,15 @@ private module LogicInput_v1 implements GuardsImpl::LogicInputSig {
predicate additionalImpliesStep( predicate additionalImpliesStep(
GuardsImpl::PreGuard g1, GuardValue v1, GuardsImpl::PreGuard g2, GuardValue v2 GuardsImpl::PreGuard g1, GuardValue v1, GuardsImpl::PreGuard g2, GuardValue v2
) { ) {
// The `ConditionalBranch` instruction is the instruction for which there are
// conditional successors out of. However, the condition that controls
// which conditional successor is taken is given by the condition of the
// `ConditionalBranch` instruction. So this step either needs to be here,
// or we need `ConditionalBranch` instructions to be `IdExpr`s. Modeling
// them as `IdExpr`s would be a bit weird since the result type is
// `IRVoidType`. Including them here is fine as long as `ConditionalBranch`
// instructions cannot be assigned to SSA variables (which they cannot
// since they produce no value).
g1.(ConditionalBranchInstruction).getCondition() = g2 and g1.(ConditionalBranchInstruction).getCondition() = g2 and
v1.asBooleanValue() = v2.asBooleanValue() v1.asBooleanValue() = v2.asBooleanValue()
} }