hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

move the "commander" source

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-12-16 15:05:59 +01:00
parent 2ae0400922
commit 99af484042
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
javascript/ql/src/semmle/javascript/security/dataflow/IndirectCommandInjectionCustomizations.qll
View File

@@ -73,6 +73,12 @@ module IndirectCommandInjection {
API::moduleImport("dashdash"),
API::moduleImport("dashdash").getMember("createParser").getReturn()
].getMember("parse").getACall()
or
// `require('commander').myCmdArgumentName`
this = commander().getAMember().getAnImmediateUse()
or
// `require('commander').opt()` => `{a: ..., b: ...}`
this = commander().getMember("opts").getACall()
}
}
@@ -105,19 +111,6 @@ module IndirectCommandInjection {
result = commander().getAMember().getReturn()
}
/**
* A source of user input from the command-line parsed by the `commander` library.
*/
private class CommanderSource extends Source {
CommanderSource() {
// the parsed commands are stored as properties on the command object.
this = commander().getAMember().getAnImmediateUse()
or
// or the `opts()` method gets a list of them.
this = commander().getMember("opts").getACall()
}
}
/**
* Gets an instance of `yargs`.
* Either directly imported as a module, or through some chained method call.