hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-23 20:26:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

updated predicates

Browse Source
This commit is contained in:
Jami Cogswell
2022-08-10 23:06:13 -04:00
parent 115f76ac5a
commit 9968d5d816
3 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
java/ql/lib/semmle/code/java/security/ImplicitlyExportedAndroidComponent.qll
View File

@@ -1,9 +1,20 @@
/** Provides a class to reason about Android implicitly exported components. */
/** Provides a class to identify implicitly exported Android components. */
private import semmle.code.xml.AndroidManifest
/** Represents an implicitly exported Android component */
class ImplicitlyExportedAndroidComponent extends AndroidComponentXmlElement {
//ImplicitlyExportedAndroidComponent() { }
// ImplicitlyExportedAndroidComponent() {
// not this.hasExportedAttribute() and
// this.hasAnIntentFilterElement() and
// not this.requiresPermissions() and
// not this.getParent().(AndroidApplicationXmlElement).hasAttribute("permission") and
// not this.getAnIntentFilterElement().hasLauncherCategoryElement() and
// not this.getFile().(AndroidManifestXmlFile).isInBuildDirectory()
// }
/**
* Holds if this Android component is implicitly exported.
*/
predicate isImplicitlyExported() {
not this.hasExportedAttribute() and
this.hasAnIntentFilterElement() and

2
java/ql/lib/semmle/code/xml/AndroidManifest.qll
View File

@@ -178,7 +178,7 @@ class AndroidComponentXmlElement extends XmlElement {
/**
* Holds if this component element has an `<intent-filter>` child element.
*/
predicate hasAnIntentFilterElement() { this.getAChild().hasName("intent-filter") }
predicate hasAnIntentFilterElement() { exists(this.getAnIntentFilterElement()) }
/**
* Gets the value of the `android:name` attribute of this component element.

3
java/ql/src/Security/CWE/CWE-926/ImplicitlyExportedAndroidComponent.ql
View File

@@ -16,3 +16,6 @@ import semmle.code.java.security.ImplicitlyExportedAndroidComponent
from ImplicitlyExportedAndroidComponent impExpAndroidComp
where impExpAndroidComp.isImplicitlyExported()
select impExpAndroidComp, "This component is implicitly exported."
// from ImplicitlyExportedAndroidComponent impExpAndroidComp
// where exists(impExpAndroidComp)
// select impExpAndroidComp, "This component is implicitly exported."