hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 03:06:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

CPP: Improved solution (mostly performance).

Browse Source
This commit is contained in:
Geoffrey White
2019-06-04 13:24:20 +01:00
parent 47ff38ef22
commit 98d80deefb
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cpp/ql/src/semmle/code/cpp/controlflow/LocalScopeVariableReachability.qll
View File

@@ -139,16 +139,17 @@ private predicate bbLoopEntryConditionAlwaysTrueAt(BasicBlock bb, int i, Control
* within a complex loop condition are not matched by this predicate. * within a complex loop condition are not matched by this predicate.
*/ */
private predicate bbLoopConditionAlwaysTrueUponEntrySuccessor(BasicBlock pred, BasicBlock succ, boolean skipsLoop) { private predicate bbLoopConditionAlwaysTrueUponEntrySuccessor(BasicBlock pred, BasicBlock succ, boolean skipsLoop) {
exists(ControlFlowNode loop | exists(Expr cond |
loopConditionAlwaysTrueUponEntry(loop, _) and loopConditionAlwaysTrueUponEntry(_, cond) and
cond.getAChild*() = pred.getEnd() and
succ = pred.getASuccessor() and
not cond.getAChild*() = succ.getStart() and
( (
( (
not succ = loop.(Loop).getStmt() and succ = pred.getAFalseSuccessor() and
pred.getAFalseSuccessor() = succ and
skipsLoop = true skipsLoop = true
) or ( ) or (
succ = loop.(Loop).getStmt() and succ = pred.getATrueSuccessor() and
pred.getATrueSuccessor() = succ and
skipsLoop = false skipsLoop = false
) )
) )