From 9883d7124e6f3f61501d1d767f7c7c1be2550fa3 Mon Sep 17 00:00:00 2001
From: Arthur Baars <aibaars@github.com>
Date: Mon, 7 Dec 2020 16:20:42 +0100
Subject: [PATCH] CFG: improve handling of redo

---
 .../controlflow/internal/ControlFlowGraphImpl.qll           | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll b/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll
index 6dd35e13e7b..b73909d58d9 100644
--- a/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll
+++ b/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll
@@ -460,7 +460,7 @@ private module Trees {
    *
    * ```rb
    * for arg in args do
-   *  puts arg
+   *   puts arg
    * end
    * puts "done";
    * ```
@@ -538,9 +538,9 @@ private module Trees {
       succ = this and
       c.continuesLoop()
       or
-      last(this.getBody(), pred, any(RedoCompletion rc)) and
+      last(this.getBody(), pred, c) and
       first(this.getBody(), succ) and
-      c instanceof SimpleCompletion
+      c instanceof RedoCompletion
     }
   }