From 97d5af7b6bc00da1b652ea3a9b51dd07374ea5cc Mon Sep 17 00:00:00 2001
From: Mathias Vorreiter Pedersen <mapeder@microsoft.com>
Date: Thu, 17 Oct 2024 11:42:29 +0100
Subject: [PATCH] PS: Add failing test.

---
 .../library-tests/dataflow/params/global.ps1     |  7 +++++--
 .../library-tests/dataflow/params/test.expected  | 16 ++++++++++++----
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/powershell/ql/test/library-tests/dataflow/params/global.ps1 b/powershell/ql/test/library-tests/dataflow/params/global.ps1
index e3850e7715d..cd73c710120 100644
--- a/powershell/ql/test/library-tests/dataflow/params/global.ps1
+++ b/powershell/ql/test/library-tests/dataflow/params/global.ps1
@@ -1,3 +1,6 @@
-param([string]$Source)
+param([string]$Source1, [string]$Source2, [string]$Source3, [string]$Source4)
 
-Sink $Source # $ hasValueFlow
\ No newline at end of file
+Sink $Source1 # $ hasValueFlow=1
+Sink $Source2 # $ hasValueFlow=2
+Sink $Source3 # $ hasValueFlow=3
+Sink $Source4 # $ MISSING: hasValueFlow=4
\ No newline at end of file
diff --git a/powershell/ql/test/library-tests/dataflow/params/test.expected b/powershell/ql/test/library-tests/dataflow/params/test.expected
index 5a477560675..b7c57725685 100644
--- a/powershell/ql/test/library-tests/dataflow/params/test.expected
+++ b/powershell/ql/test/library-tests/dataflow/params/test.expected
@@ -1,6 +1,8 @@
 models
 edges
-| global.ps1:1:7:1:22 | Source | global.ps1:3:6:3:13 | Source | provenance |  |
+| global.ps1:1:7:1:23 | Source1 | global.ps1:3:6:3:14 | Source1 | provenance |  |
+| global.ps1:1:25:1:41 | Source2 | global.ps1:4:6:4:14 | Source2 | provenance |  |
+| global.ps1:1:43:1:59 | Source3 | global.ps1:5:6:5:14 | Source3 | provenance |  |
 | test.ps1:1:14:1:16 | a | test.ps1:2:10:2:12 | a | provenance |  |
 | test.ps1:5:6:5:16 | Source | test.ps1:6:5:6:7 | x | provenance |  |
 | test.ps1:6:5:6:7 | x | test.ps1:1:14:1:16 | a | provenance |  |
@@ -140,8 +142,12 @@ edges
 | test.ps1:39:24:39:31 | second | test.ps1:8:24:8:26 | y | provenance |  |
 | test.ps1:39:32:39:38 | first | test.ps1:8:20:8:22 | x | provenance |  |
 nodes
-| global.ps1:1:7:1:22 | Source | semmle.label | Source |
-| global.ps1:3:6:3:13 | Source | semmle.label | Source |
+| global.ps1:1:7:1:23 | Source1 | semmle.label | Source1 |
+| global.ps1:1:25:1:41 | Source2 | semmle.label | Source2 |
+| global.ps1:1:43:1:59 | Source3 | semmle.label | Source3 |
+| global.ps1:3:6:3:14 | Source1 | semmle.label | Source1 |
+| global.ps1:4:6:4:14 | Source2 | semmle.label | Source2 |
+| global.ps1:5:6:5:14 | Source3 | semmle.label | Source3 |
 | test.ps1:1:14:1:16 | a | semmle.label | a |
 | test.ps1:2:10:2:12 | a | semmle.label | a |
 | test.ps1:5:6:5:16 | Source | semmle.label | Source |
@@ -224,7 +230,9 @@ nodes
 subpaths
 testFailures
 #select
-| global.ps1:3:6:3:13 | Source | global.ps1:1:7:1:22 | Source | global.ps1:3:6:3:13 | Source | $@ | global.ps1:1:7:1:22 | Source | Source |
+| global.ps1:3:6:3:14 | Source1 | global.ps1:1:7:1:23 | Source1 | global.ps1:3:6:3:14 | Source1 | $@ | global.ps1:1:7:1:23 | Source1 | Source1 |
+| global.ps1:4:6:4:14 | Source2 | global.ps1:1:25:1:41 | Source2 | global.ps1:4:6:4:14 | Source2 | $@ | global.ps1:1:25:1:41 | Source2 | Source2 |
+| global.ps1:5:6:5:14 | Source3 | global.ps1:1:43:1:59 | Source3 | global.ps1:5:6:5:14 | Source3 | $@ | global.ps1:1:43:1:59 | Source3 | Source3 |
 | test.ps1:2:10:2:12 | a | test.ps1:5:6:5:16 | Source | test.ps1:2:10:2:12 | a | $@ | test.ps1:5:6:5:16 | Source | Source |
 | test.ps1:9:10:9:12 | x | test.ps1:14:10:14:20 | Source | test.ps1:9:10:9:12 | x | $@ | test.ps1:14:10:14:20 | Source | Source |
 | test.ps1:10:10:10:12 | y | test.ps1:15:11:15:21 | Source | test.ps1:10:10:10:12 | y | $@ | test.ps1:15:11:15:21 | Source | Source |