hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Modified comments to reflect 'as' changes

Browse Source
This commit is contained in:
Napalys
2024-11-29 15:35:18 +01:00
parent e33f7aa1c7
commit 96c1086dfc
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ql/ql/src/queries/style/ValidatePredicateGetReturns.ql
View File

@@ -1,6 +1,6 @@
/** /**
* @name Predicates starting with "get" should return a value * @name Predicates starting with "get" or "as" should return a value
* @description Checks if predicates that start with "get" actually return a value. * @description Checks if predicates that start with "get" or "as" actually return a value.
* @kind problem * @kind problem
* @problem.severity warning * @problem.severity warning
* @id ql/predicates-get-should-return-value * @id ql/predicates-get-should-return-value
@@ -13,7 +13,7 @@ import ql
import codeql_ql.ast.Ast import codeql_ql.ast.Ast
/** /**
* Identifies predicates whose names start with "get" followed by an uppercase letter. * Identifies predicates whose names start with "get", "as" followed by an uppercase letter.
* This ensures that only predicates like "getValue" are matched, excluding names like "getter". * This ensures that only predicates like "getValue" are matched, excluding names like "getter".
*/ */
predicate isGetPredicate(Predicate pred) { pred.getName().regexpMatch("(get|as)[A-Z].*") } predicate isGetPredicate(Predicate pred) { pred.getName().regexpMatch("(get|as)[A-Z].*") }