hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

add missing expectation to tests

Browse Source
This commit is contained in:
Jami Cogswell
2022-09-28 16:22:49 -04:00
committed by Tony Torralba
parent 1857a5d311
commit 960e9db2fb
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/ql/test/library-tests/frameworks/android/intent/TestStartActivityToGetIntent.java
View File

@@ -12,17 +12,29 @@ public class TestStartActivityToGetIntent {
public void test(Context ctx, Activity act) {
// test methods that start an activity
// test all methods that start an activity
{
Intent intent = new Intent(null, SomeActivity.class);
intent.putExtra("data", (String) source("ctx-start"));
ctx.startActivity(intent);
}
{
Intent intent = new Intent(null, SomeActivity.class);
intent.putExtra("data", (String) source("ctx-start-acts"));
Intent[] intents = new Intent[] {intent};
ctx.startActivities(intents);
}
{
Intent intent = new Intent(null, SomeActivity.class);
intent.putExtra("data", (String) source("act-start"));
act.startActivity(intent);
}
{
Intent intent = new Intent(null, SomeActivity.class);
intent.putExtra("data", (String) source("act-start-acts"));
Intent[] intents = new Intent[] {intent};
act.startActivities(intents);
}
{
Intent intent = new Intent(null, SomeActivity.class);
intent.putExtra("data", (String) source("start-for-result"));
@@ -67,7 +79,7 @@ public class TestStartActivityToGetIntent {
static class SomeActivity extends Activity {
public void test() {
sink(getIntent().getStringExtra("data")); // $ hasValueFlow=ctx-start hasValueFlow=act-start hasValueFlow=start-for-result hasValueFlow=start-if-needed hasValueFlow=start-matching hasValueFlow=start-from-child hasValueFlow=start-from-frag hasValueFlow=4-arg
sink(getIntent().getStringExtra("data")); // $ hasValueFlow=ctx-start hasValueFlow=act-start hasValueFlow=start-for-result hasValueFlow=start-if-needed hasValueFlow=start-matching hasValueFlow=start-from-child hasValueFlow=start-from-frag hasValueFlow=4-arg MISSING: hasValueFlow=ctx-start-acts hasValueFlow=act-start-acts
}
}