hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add explanatory commented for MapIterator model

Browse Source
This commit is contained in:
Owen Mansel-Chan
2021-08-04 14:01:00 +01:00
parent 2ba41df2ba
commit 9533f12e24
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/semmle/code/java/frameworks/apache/Collections.qll
View File

@@ -84,6 +84,8 @@ private class ApacheCollectionsModel extends SummaryModelCsv {
"org.apache.commons.collections4;IterableGet;true;mapIterator;;;MapValue of Argument[-1];MapValue of ReturnValue;value",
"org.apache.commons.collections4;KeyValue;true;getKey;;;MapKey of Argument[-1];ReturnValue;value",
"org.apache.commons.collections4;KeyValue;true;getValue;;;MapValue of Argument[-1];ReturnValue;value",
// Note that MapIterator<K, V> implements Iterator<K>, so it iterates over the keys of the map.
// In order for the models of Iterator to work we have to use Element instead of MapKey for key data.
"org.apache.commons.collections4;MapIterator;true;getKey;;;Element of Argument[-1];ReturnValue;value",
"org.apache.commons.collections4;MapIterator;true;getValue;;;MapValue of Argument[-1];ReturnValue;value",
"org.apache.commons.collections4;MapIterator;true;next;;;Element of Argument[-1];ReturnValue;value",