hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 11:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Highlight problem picking DataFlow::Node for Assign

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2021-06-29 15:32:16 +02:00
parent 9573048ee8
commit 94bcda3bae
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
python/ql/src/semmle/python/frameworks/Aiohttp.qll
View File

@@ -646,8 +646,9 @@ module AiohttpWebModel {
AiohttpResponseCookieSubscriptWrite() {
exists(Assign assign, Subscript subscript |
// there doesn't seem to be any _good_ choice for `this`, so just picking the
// whole subscript...
// Since there is no `DataFlow::Node` for the assign (since it's a statement,
// and not an expression) there doesn't seem to be any _good_ choice for `this`,
// so just picking the whole subscript...
this.asExpr() = subscript
|
assign.getATarget() = subscript and

5
python/ql/src/semmle/python/frameworks/Django.qll
View File

@@ -1413,8 +1413,9 @@ private module PrivateDjango {
DjangoResponseCookieSubscriptWrite() {
exists(Assign assign, Subscript subscript, DataFlow::AttrRead cookieLookup |
// there doesn't seem to be any _good_ choice for `this`, so just picking the
// whole subscript...
// Since there is no `DataFlow::Node` for the assign (since it's a statement,
// and not an expression) there doesn't seem to be any _good_ choice for `this`,
// so just picking the whole subscript...
this.asExpr() = subscript
|
cookieLookup.getAttributeName() = "cookies" and