hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Owen Mansel-Chan
2021-06-17 10:29:33 +01:00
parent b9bc1f978c
commit 945db01f56
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/src/semmle/code/java/frameworks/JaxWS.qll
View File

@@ -81,13 +81,13 @@ class JaxRsResourceMethod extends Method {
result = this.getAnAnnotation() result = this.getAnAnnotation()
or or
// No direct annotations // No direct annotations
not exists(this.getAnAnnotation().(JaxRSProducesAnnotation)) and not this.getAnAnnotation() instanceof JaxRSProducesAnnotation and
( (
// Annotations on a method we've overridden // Annotations on a method we've overridden
result = this.getAnOverride().getAnAnnotation() result = this.getAnOverride().getAnAnnotation()
or or
// No annotations on this method, or a method we've overridden, so look to the class // No annotations on this method, or a method we've overridden, so look to the class
not exists(this.getAnOverride().getAnAnnotation().(JaxRSProducesAnnotation)) and not this.getAnOverride().getAnAnnotation() instanceof JaxRSProducesAnnotation and
result = this.getDeclaringType().getAnAnnotation() result = this.getDeclaringType().getAnAnnotation()
) )
} }
@@ -267,7 +267,7 @@ class MessageBodyReader extends GenericInterface {
*/ */
class MessageBodyReaderReadFrom extends Method { class MessageBodyReaderReadFrom extends Method {
MessageBodyReaderReadFrom() { MessageBodyReaderReadFrom() {
this.getDeclaringType().(RefType).getSourceDeclaration() instanceof MessageBodyReader and this.getDeclaringType().getSourceDeclaration() instanceof MessageBodyReader and
this.hasName("readFrom") this.hasName("readFrom")
} }
} }