hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 08:43:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21009 from geoffw0/varfps

Browse Source 
Rust: Fix some false positives for rust/unused-variable and rust/unused-value
This commit is contained in:
Geoffrey White
2025-12-15 09:48:47 +00:00
committed by GitHub
parent 949cfc3fbd 01f9b42472
commit 93e8534d0a
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rust/ql/src/change-notes/2025-12-10-unused-variable.md Normal file
View File

@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Fixed common false positives for the `rust/unused-variable` and `rust/unused-value` queries.

6
rust/ql/src/queries/unusedentities/UnusedVariable.qll
View File

@@ -43,4 +43,10 @@ predicate isAllowableUnused(Variable v) {
or or
// a 'self' variable // a 'self' variable
v.getText() = "self" v.getText() = "self"
or
// a common source of false positives is match arms containing constants
// (typically beginning with a capital letter) that are misrecognized as a
// variable, having not been correctly resolved.
v.getPat().getParentNode() instanceof MatchArm and
v.getText().charAt(0).isUppercase()
} }