mirror of
https://github.com/github/codeql.git
synced 2026-05-14 11:19:27 +02:00
Address review comments on path-injection[read] sub-kind
- shared/mad/codeql/mad/ModelValidation.qll: shorten the comment for `path-injection[%]` to `// Java-only currently`, matching the style of other language-scoped entries and dropping API examples and the java/zipslip reference. - java/ql/lib/semmle/code/java/security/ZipSlipQuery.qll: replace the `File.exists` example in the QLDoc with `FileReader`, since `File.exists` is still labelled plain `path-injection`, not `path-injection[read]`.
This commit is contained in:
@@ -55,8 +55,8 @@ module ZipSlipFlow = TaintTracking::Global<ZipSlipConfig>;
|
||||
*
|
||||
* This deliberately selects only the `path-injection` sink kind and excludes
|
||||
* `path-injection[read]`: Zip Slip is an archive-extraction vulnerability, so
|
||||
* read-only path sinks (e.g. `ClassLoader.getResource`, `FileInputStream`,
|
||||
* `File.exists`) are outside the threat model.
|
||||
* read-only path sinks (for example `ClassLoader.getResource`,
|
||||
* `FileInputStream`, and `FileReader`) are outside the threat model.
|
||||
*/
|
||||
private class FileCreationSink extends DataFlow::Node {
|
||||
FileCreationSink() { sinkNode(this, "path-injection") }
|
||||
|
||||
Reference in New Issue
Block a user