mirror of
https://github.com/github/codeql.git
synced 2025-12-24 04:36:35 +01:00
Apply suggestions from code review for netty DefaultHttpHeaders
Co-Authored-By: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
This commit is contained in:
committed by
GitHub
parent
dcbd6e0a11
commit
934eed97df
@@ -4,6 +4,6 @@ public class ResponseSplitting {
|
||||
// BAD: Disables the internal response splitting verification
|
||||
private final DefaultHttpHeaders badHeaders = new DefaultHttpHeaders(false);
|
||||
|
||||
// GOOD: Verifies headers passed don't contain CLRF characters
|
||||
// GOOD: Verifies headers passed don't contain CRLF characters
|
||||
private final DefaultHttpHeaders badHeaders = new DefaultHttpHeaders();
|
||||
}
|
||||
|
||||
@@ -1,3 +1,16 @@
|
||||
/**
|
||||
* @name Disabled Netty HTTP header validation
|
||||
* @description Disabling HTTP header validation makes code vulnerable to
|
||||
* attack by header splitting if user input is written directly to
|
||||
* an HTTP header.
|
||||
* @kind problem
|
||||
* @problem.severity error
|
||||
* @precision high
|
||||
* @id java/netty-http-response-splitting
|
||||
* @tags security
|
||||
* external/cwe/cwe-113
|
||||
*/
|
||||
|
||||
import java
|
||||
|
||||
from ClassInstanceExpr new
|
||||
|
||||
Reference in New Issue
Block a user