From 70e72aadd599fe94740dc4b66d129b7112cf829f Mon Sep 17 00:00:00 2001 From: Paolo Tranquilli Date: Fri, 12 Apr 2024 14:57:59 +0200 Subject: [PATCH 1/2] Swift: accept new test results --- .../Security/CWE-311/CleartextTransmission.expected | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/swift/ql/test/query-tests/Security/CWE-311/CleartextTransmission.expected b/swift/ql/test/query-tests/Security/CWE-311/CleartextTransmission.expected index f7cc15bf8b1..29cc795c196 100644 --- a/swift/ql/test/query-tests/Security/CWE-311/CleartextTransmission.expected +++ b/swift/ql/test/query-tests/Security/CWE-311/CleartextTransmission.expected @@ -27,19 +27,10 @@ edges | testURL.swift:104:16:104:57 | call to SecKeyCopyExternalRepresentation(_:_:) | testURL.swift:105:32:105:32 | data | provenance | | | testURL.swift:104:16:104:57 | call to SecKeyCopyExternalRepresentation(_:_:) | testURL.swift:106:20:106:20 | "..." | provenance | AdditionalTaintStep | | testURL.swift:105:6:105:10 | let ...? [some:0] | testURL.swift:105:10:105:10 | string | provenance | | -| testURL.swift:105:6:105:10 | let ...? [some:0] | testURL.swift:105:10:105:10 | string | provenance | | -| testURL.swift:105:6:105:10 | let ...? [some:0] | testURL.swift:105:10:105:10 | string | provenance | | -| testURL.swift:105:6:105:10 | let ...? [some:0] | testURL.swift:105:10:105:10 | string | provenance | | | testURL.swift:105:10:105:10 | string | testURL.swift:106:20:106:20 | "..." | provenance | | -| testURL.swift:105:10:105:10 | string | testURL.swift:106:20:106:20 | "..." | provenance | | -| testURL.swift:105:19:105:53 | call to String.init(data:encoding:) | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | provenance | | | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | provenance | | | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) | testURL.swift:106:20:106:20 | "..." | provenance | | | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | testURL.swift:105:6:105:10 | let ...? [some:0] | provenance | | -| testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | testURL.swift:105:6:105:10 | let ...? [some:0] | provenance | | -| testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | testURL.swift:105:6:105:10 | let ...? [some:0] | provenance | | -| testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | testURL.swift:105:6:105:10 | let ...? [some:0] | provenance | | -| testURL.swift:105:32:105:32 | data | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | provenance | | | testURL.swift:105:32:105:32 | data | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | provenance | | nodes | file://:0:0:0:0 | .value | semmle.label | .value | @@ -94,12 +85,9 @@ nodes | testURL.swift:96:51:96:51 | certificate | semmle.label | certificate | | testURL.swift:104:16:104:57 | call to SecKeyCopyExternalRepresentation(_:_:) | semmle.label | call to SecKeyCopyExternalRepresentation(_:_:) | | testURL.swift:105:6:105:10 | let ...? [some:0] | semmle.label | let ...? [some:0] | -| testURL.swift:105:6:105:10 | let ...? [some:0] | semmle.label | let ...? [some:0] | -| testURL.swift:105:10:105:10 | string | semmle.label | string | | testURL.swift:105:10:105:10 | string | semmle.label | string | | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) | semmle.label | call to String.init(data:encoding:) | | testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | semmle.label | call to String.init(data:encoding:) [some:0] | -| testURL.swift:105:19:105:53 | call to String.init(data:encoding:) [some:0] | semmle.label | call to String.init(data:encoding:) [some:0] | | testURL.swift:105:32:105:32 | data | semmle.label | data | | testURL.swift:106:20:106:20 | "..." | semmle.label | "..." | subpaths From de4ffbb55283642e6681f088b6e3baee4dfe5090 Mon Sep 17 00:00:00 2001 From: Paolo Tranquilli Date: Fri, 12 Apr 2024 15:35:39 +0200 Subject: [PATCH 2/2] Swift: add `shared/**` to CI triggers Not being triggered by changes in shared was making it possible to not notice changes in `shared` having effect on Swift tests. For example [this PR](https://github.com/github/codeql/pull/15501) introduced a test change that was fixed [here](https://github.com/github/codeql/pull/16197). --- .github/workflows/swift.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/swift.yml b/.github/workflows/swift.yml index 6956d31a398..9e736e3225b 100644 --- a/.github/workflows/swift.yml +++ b/.github/workflows/swift.yml @@ -6,6 +6,7 @@ on: - "swift/**" - "misc/bazel/**" - "misc/codegen/**" + - "shared/**" - "*.bazel*" - .github/workflows/swift.yml - .github/actions/** @@ -22,10 +23,12 @@ on: - "swift/**" - "misc/bazel/**" - "misc/codegen/**" + - "shared/**" - "*.bazel*" - .github/workflows/swift.yml - .github/actions/** - codeql-workspace.yml + - .pre-commit-config.yaml - "!**/*.md" - "!**/*.qhelp" branches: