hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Fix some FPs in IncorrectSuffixCheck

Browse Source
This commit is contained in:
Asger F
2019-05-13 08:54:07 +01:00
parent 649979de3e
commit 9293010e4c
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/test/query-tests/Security/CWE-020/tst.js
View File

@@ -79,3 +79,13 @@ function withIndexOfCheckBad(x, y) {
function plus(x, y) {
return x.indexOf("." + y) === x.length - (y.length + 1); // NOT OK
}
function withIndexOfCheckLower(x, y) {
let index = x.indexOf(y);
return !(index < 0) && index === x.length - y.length - 1; // OK
}
function withIndexOfCheckLowerEq(x, y) {
let index = x.indexOf(y);
return !(index <= -1) && index === x.length - y.length - 1; // OK
}