hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 16:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Address more review comments.

Browse Source
This commit is contained in:
Michael Nebel
2024-02-13 13:15:17 +01:00
parent 8efe34942f
commit 91bbbe262d
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
View File

@@ -1803,10 +1803,10 @@ class FlowSummaryNode extends NodeImpl, TFlowSummaryNode {
* public void SetParam(object value) => o = value; // (2)
* }
* ```
* the first access to o (1) is modeled as this.o_backing_field and
* the second access to o (2) is modeled as this.o_backing_field = value.
* the first access to o (1) is modeled as `this.o_backing_field` and
* the second access to o (2) is modeled as `this.o_backing_field = value`.
* Both models need a pre-update this node, and the latter need an additional post-update this access,
* all of which are represented by an InstanceParameterAccessNode node.
* all of which are represented by an `InstanceParameterAccessNode` node.
*/
class InstanceParameterAccessNode extends NodeImpl, TInstanceParameterAccessNode {
private ControlFlow::Node cfn;
@@ -1853,11 +1853,11 @@ class InstanceParameterAccessNode extends NodeImpl, TInstanceParameterAccessNode
* ```csharp
* public class C(object o) { }
* ```
* we synthesize the primary constructor for C as
* we synthesize the primary constructor for `C` as
* ```csharp
* public C(object o) => this.o_backing_field = o;
* ```
* The synthesized (pre/post-update) this access is represented an PrimaryConstructorThisAccessNode node.
* The synthesized (pre/post-update) this access is represented an `PrimaryConstructorThisAccessNode` node.
*/
class PrimaryConstructorThisAccessNode extends NodeImpl, TPrimaryConstructorThisAccessNode {
private Parameter p;