hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 11:16:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++/C#: Fix phantom Chi definitions in PrintSSA

Browse Source 
When `PrintSSA.qll` is imported, IR dumps will be annotated with the alias analysis information used during SSA construction. When printing this information, we incorrectly treated instructions at offset -1, which should only be `Phi` instructions, as `Chi` instructions for the instruction at offset 0. This produced phantom annotations, but did not affect the correctness of the actual IR.
This commit is contained in:
Dave Bartolomeo
2020-04-15 18:24:11 -04:00
parent 0d86866ba3
commit 90dc14c56e
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/PrintSSA.qll
View File

@@ -6,11 +6,12 @@ private import DebugSSA
bindingset[offset] bindingset[offset]
private string getKeySuffixForOffset(int offset) { private string getKeySuffixForOffset(int offset) {
offset >= 0 and
if offset % 2 = 0 then result = "" else result = "_Chi" if offset % 2 = 0 then result = "" else result = "_Chi"
} }
bindingset[offset] bindingset[offset]
private int getIndexForOffset(int offset) { result = offset / 2 } private int getIndexForOffset(int offset) { offset >= 0 and result = offset / 2 }
/** /**
* Property provide that dumps the memory access of each result. Useful for debugging SSA * Property provide that dumps the memory access of each result. Useful for debugging SSA

3
cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/PrintSSA.qll
View File

@@ -6,11 +6,12 @@ private import DebugSSA
bindingset[offset] bindingset[offset]
private string getKeySuffixForOffset(int offset) { private string getKeySuffixForOffset(int offset) {
offset >= 0 and
if offset % 2 = 0 then result = "" else result = "_Chi" if offset % 2 = 0 then result = "" else result = "_Chi"
} }
bindingset[offset] bindingset[offset]
private int getIndexForOffset(int offset) { result = offset / 2 } private int getIndexForOffset(int offset) { offset >= 0 and result = offset / 2 }
/** /**
* Property provide that dumps the memory access of each result. Useful for debugging SSA * Property provide that dumps the memory access of each result. Useful for debugging SSA

3
csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/internal/PrintSSA.qll
View File

@@ -6,11 +6,12 @@ private import DebugSSA
bindingset[offset] bindingset[offset]
private string getKeySuffixForOffset(int offset) { private string getKeySuffixForOffset(int offset) {
offset >= 0 and
if offset % 2 = 0 then result = "" else result = "_Chi" if offset % 2 = 0 then result = "" else result = "_Chi"
} }
bindingset[offset] bindingset[offset]
private int getIndexForOffset(int offset) { result = offset / 2 } private int getIndexForOffset(int offset) { offset >= 0 and result = offset / 2 }
/** /**
* Property provide that dumps the memory access of each result. Useful for debugging SSA * Property provide that dumps the memory access of each result. Useful for debugging SSA