Java: Expand ExactPathSanitizer to work on the argument of 'equals' too

2026-04-26 17:25:19 +02:00 · 2024-02-15 09:54:29 +01:00
parent 8aff913c3c
commit 90a9d82b9d
4 changed files with 19 additions and 1 deletions
--- a/java/ql/lib/semmle/code/java/security/PathSanitizer.qll
+++ b/java/ql/lib/semmle/code/java/security/PathSanitizer.qll
@@ -56,7 +56,7 @@ private predicate exactPathMatchGuard(Guard g, Expr e, boolean branch) {
    t instanceof StringsKt or
    t instanceof FilesKt
  |
-    e = getVisualQualifier(ma).getUnderlyingExpr() and
+    e = [getVisualQualifier(ma).getUnderlyingExpr(), getVisualArgument(ma, 0)] and
    ma.getMethod().getDeclaringType() = t and
    ma = g and
    getSourceMethod(ma.getMethod()).hasName(["equals", "equalsIgnoreCase"]) and