hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 18:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: Fix bug in model flow sanitizer.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2022-02-04 15:08:35 +01:00
committed by Michael Nebel
parent 16a5ccddea
commit 908cc40c9f
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/utils/model-generator/CaptureSummaryModels.ql
View File

@@ -80,7 +80,9 @@ class ThroughFlowConfig extends TaintTracking::Configuration {
) )
} }
override predicate isSanitizer(DataFlow::Node n) { not isRelevantType(n.getType()) } override predicate isSanitizer(DataFlow::Node n) {
exists(Type t | t = n.getType() and not isRelevantType(t))
}
override DataFlow::FlowFeature getAFeature() { override DataFlow::FlowFeature getAFeature() {
result instanceof DataFlow::FeatureEqualSourceSinkCallContext result instanceof DataFlow::FeatureEqualSourceSinkCallContext

1
java/ql/test/utils/model-generator/CaptureSummaryModels.expected
View File

@@ -21,7 +21,6 @@
| p;Joiner;false;merge;(Joiner);;Argument[-1];ReturnValue;value | | p;Joiner;false;merge;(Joiner);;Argument[-1];ReturnValue;value |
| p;Joiner;false;setEmptyValue;(CharSequence);;Argument[-1];ReturnValue;value | | p;Joiner;false;setEmptyValue;(CharSequence);;Argument[-1];ReturnValue;value |
| p;Joiner;false;setEmptyValue;(CharSequence);;Argument[0];Argument[-1];taint | | p;Joiner;false;setEmptyValue;(CharSequence);;Argument[0];Argument[-1];taint |
| p;Joiner;false;setEmptyValue;(CharSequence);;Argument[0];ReturnValue;taint |
| p;Joiner;false;toString;();;Argument[-1];ReturnValue;taint | | p;Joiner;false;toString;();;Argument[-1];ReturnValue;taint |
| p;MultipleImpls$Strat2;true;getValue;();;Argument[-1];ReturnValue;taint | | p;MultipleImpls$Strat2;true;getValue;();;Argument[-1];ReturnValue;taint |
| p;MultipleImpls$Strategy;true;doSomething;(String);;Argument[0];Argument[-1];taint | | p;MultipleImpls$Strategy;true;doSomething;(String);;Argument[0];Argument[-1];taint |