hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: remove isArgOf predicate

Browse Source
This commit is contained in:
Stephan Brandauer
2023-09-06 09:24:25 +02:00
parent caaf2f83d7
commit 902a585b47
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
java/ql/automodel/src/AutomodelApplicationModeCharacteristics.qll
View File

@@ -42,11 +42,9 @@ newtype TApplicationModeEndpoint =
* An endpoint is a node that is a candidate for modeling. * An endpoint is a node that is a candidate for modeling.
*/ */
abstract private class ApplicationModeEndpoint extends TApplicationModeEndpoint { abstract private class ApplicationModeEndpoint extends TApplicationModeEndpoint {
abstract predicate isArgOf(Call c, int idx); abstract Call getCall();
Call getCall() { this.isArgOf(result, _) } abstract int getArgIndex();
int getArgIndex() { this.isArgOf(_, result) }
abstract Top asTop(); abstract Top asTop();
@@ -66,7 +64,9 @@ class ExplicitArgument extends ApplicationModeEndpoint, TExplicitArgument {
ExplicitArgument() { this = TExplicitArgument(call, arg) } ExplicitArgument() { this = TExplicitArgument(call, arg) }
override predicate isArgOf(Call c, int idx) { c = call and this.asTop() = c.getArgument(idx) } override Call getCall() { result = call }
override int getArgIndex() { this.asTop() = call.getArgument(result) }
override Top asTop() { result = arg.asExpr() } override Top asTop() { result = arg.asExpr() }
@@ -83,9 +83,9 @@ class InstanceArgument extends ApplicationModeEndpoint, TInstanceArgument {
InstanceArgument() { this = TInstanceArgument(call, arg) } InstanceArgument() { this = TInstanceArgument(call, arg) }
override predicate isArgOf(Call c, int idx) { override Call getCall() { result = call }
c = call and this.asTop() = c.getQualifier() and idx = -1
} override int getArgIndex() { result = -1 }
override Top asTop() { if exists(arg.asExpr()) then result = arg.asExpr() else result = call } override Top asTop() { if exists(arg.asExpr()) then result = arg.asExpr() else result = call }
@@ -112,7 +112,9 @@ class ImplicitVarargsArray extends ApplicationModeEndpoint, TImplicitVarargsArra
ImplicitVarargsArray() { this = TImplicitVarargsArray(call, vararg, idx) } ImplicitVarargsArray() { this = TImplicitVarargsArray(call, vararg, idx) }
override predicate isArgOf(Call c, int i) { c = call and i = idx } override Call getCall() { result = call }
override int getArgIndex() { result = idx }
override Top asTop() { result = this.getCall() } override Top asTop() { result = this.getCall() }
@@ -131,7 +133,9 @@ class MethodCall extends ApplicationModeEndpoint, TMethodCall {
MethodCall() { this = TMethodCall(call) } MethodCall() { this = TMethodCall(call) }
override predicate isArgOf(Call c, int idx) { c = call and idx = -1 } override Call getCall() { result = call }
override int getArgIndex() { result = -1 }
override Top asTop() { result = call } override Top asTop() { result = call }