hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Fix bad join in globalVariableNestedFieldJumpStep

Browse Source
This commit is contained in:
Taus
2025-09-16 15:13:31 +00:00
committed by Napalys Klicius
parent 431fc8880e
commit 8fd62252fd
1 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
View File

@@ -561,18 +561,36 @@ predicate runtimeJumpStep(Node nodeFrom, Node nodeTo) {
globalVariableNestedFieldJumpStep(nodeFrom, nodeTo)
}
/** Helper predicate for `globalVariableNestedFieldJumpStep`. */
pragma[nomagic]
private predicate globalVariableAttrPathRead(
ModuleVariableNode globalVar, string accessPath, AttrRead r, string attrName
) {
globalVariableAttrPathAtDepth(globalVar, accessPath, r.getObject(), _) and
attrName = r.getAttributeName()
}
/** Helper predicate for `globalVariableNestedFieldJumpStep`. */
pragma[nomagic]
private predicate globalVariableAttrPathWrite(
ModuleVariableNode globalVar, string accessPath, AttrWrite w, string attrName
) {
globalVariableAttrPathAtDepth(globalVar, accessPath, w.getObject(), _) and
attrName = w.getAttributeName()
}
/**
* Holds if there is a jump step from `nodeFrom` to `nodeTo` through global variable field access.
* This supports tracking nested object field access through global variables like `app.obj.foo`.
*/
pragma[nomagic]
private predicate globalVariableNestedFieldJumpStep(Node nodeFrom, Node nodeTo) {
exists(ModuleVariableNode globalVar, AttrWrite write, AttrRead read |
// Match writes and reads on the same global variable attribute path
exists(string accessPath |
globalVariableAttrPathAtDepth(globalVar, accessPath, write.getObject(), _) and
globalVariableAttrPathAtDepth(globalVar, accessPath, read.getObject(), _)
exists(string accessPath, string attrName |
globalVariableAttrPathRead(globalVar, accessPath, read, attrName) and
globalVariableAttrPathWrite(globalVar, accessPath, write, attrName)
) and
write.getAttributeName() = read.getAttributeName() and
nodeFrom = write.getValue() and
nodeTo = read
)