hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Test improvements

Browse Source
This commit is contained in:
Ed Minnix
2023-03-02 11:00:24 -05:00
parent fa416564c7
commit 8fcf00b73d
1 changed files with 7 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
java/ql/test/query-tests/security/CWE-094/APKInstallation.java
View File

@@ -15,58 +15,41 @@ public class APKInstallation extends Activity {
startActivity(intent);
}
public void downloadAPK(String url) {
// BAD: the url is not checked
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setDataAndType(Uri.parse(url), "application/vnd.android.package-archive");
startActivity(intent);
}
public void installAPK2() {
String path = "file:///sdcard/Download/MyApp.apk";
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setType("application/vnd.android.package-archive");
intent.setData(Uri.parse(path));
startActivity(intent);
}
public void installAPK3(String path) {
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setType(APK_MIMETYPE);
// BAD: the path is not checked
intent.setData(Uri.fromFile(new File(path)));
startActivity(intent);
}
public void installAPK4(String path) {
public void installAPKFromExternalStorage(String path) {
// BAD: file is from external storage
File file = new File(Environment.getExternalStorageDirectory(), path);
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setDataAndType(Uri.fromFile(file), APK_MIMETYPE);
startActivity(intent);
}
public void installAPK5(String path) {
public void installAPKFromExternalStorageWithActionInstallPackage(String path) {
// BAD: file is from external storage
File file = new File(Environment.getExternalStorageDirectory(), path);
Intent intent = new Intent(Intent.ACTION_INSTALL_PACKAGE);
intent.setData(Uri.fromFile(file));
startActivity(intent);
}
public void installAPK6(String path) {
public void installAPKInstallPackageLiteral(String path) {
File file = new File(Environment.getExternalStorageDirectory(), path);
Intent intent = new Intent("android.intent.action.INSTALL_PACKAGE");
intent.setData(Uri.fromFile(file));
startActivity(intent);
}
public void openWebsite() {
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setData(Uri.parse("http://www.example.com"));
startActivity(intent);
}
public void otherIntent(File file) {
Intent intent = new Intent(this, OtherActivity.class);
intent.setAction(Intent.ACTION_VIEW);
// BAD: the file is from unknown source
intent.setData(Uri.fromFile(file));
}
}