hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 03:06:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid recursion through extractFunctionLaterIfExternalFileMember -> useType -> useDeclarationParent

Browse Source
This commit is contained in:
Chris Smowton
2022-03-08 17:48:53 +00:00
committed by Ian Lynagh
parent 1835022c84
commit 8f929e2498
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt
View File

@@ -246,7 +246,10 @@ open class KotlinUsesExtractor(
// getters and setters are extracted alongside it
return
}
val paramTypes = f.valueParameters.map { useType(it.type) }
// Note we erase the parameter types before calling useType even though the signature should be the same
// in order to prevent an infinite loop through useTypeParameter -> useDeclarationParent -> useFunction
// -> extractFunctionLaterIfExternalFileMember, which would result for `fun <T> f(t: T) { ... }` for example.
val paramTypes = f.valueParameters.map { useType(erase(it.type)) }
val signature = paramTypes.joinToString(separator = ",", prefix = "(", postfix = ")") { it.javaResult.signature!! }
dependencyCollector?.addDependency(f, signature)
externalClassExtractor.extractLater(f, signature)