hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 03:06:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: add comment about namespace packages

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2023-08-15 12:02:02 +02:00
parent 307f44339c
commit 8f70c9f950
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
python/ql/lib/semmle/python/Module.qll
View File

@@ -195,6 +195,14 @@ private predicate isPotentialPackage(Folder f) {
}
private string moduleNameFromBase(Container file) {
// We used to also require `isPotentialPackage(f)` to hold in this case,
// but we saw modules not getting resolved because their folder did not
// contain an `__init__.py` file.
//
// This makes the folder not be a package but a namespace package instead.
//
// It is possible that we can keep the requirement here, but relax
// `isPotentialPackage` itself to allow for namespace packages.
result = file.getBaseName()
or
file instanceof File and result = file.getStem()