hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12146 from jketema/global-indirect

Browse Source 
C++: Do not mark global indirect flow as spurious in dataflow tests
This commit is contained in:
Jeroen Ketema
2023-02-10 10:21:04 +01:00
committed by GitHub
parent 9aa9187dd7 350fb89ebf
commit 8f15abc285
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/test/library-tests/dataflow/dataflow-tests/test.cpp
View File

@@ -563,18 +563,18 @@ namespace IndirectFlowThroughGlobals {
} }
void f() { void f() {
sink(*globalInt); // $ ir=562:17 ir=576:17 // tainted or clean? Not sure. sink(*globalInt); // $ ir=562:17 ir=576:17 MISSING: ast=562:17 ast=576:17
taintGlobal(); taintGlobal();
sink(*globalInt); // $ ir=562:17 MISSING: ast=562:17 SPURIOUS: ir=576:17 sink(*globalInt); // $ ir=562:17 ir=576:17 MISSING: ast=562:17 ast=576:17
} }
void calledAfterTaint() { void calledAfterTaint() {
sink(*globalInt); // $ ir=576:17 MISSING: ast=576:17 SPURIOUS: ir=562:17 sink(*globalInt); // $ ir=562:17 ir=576:17 MISSING: ast=562:17 ast=576:17
} }
void taintAndCall() { void taintAndCall() {
globalInt = indirect_source(); globalInt = indirect_source();
calledAfterTaint(); calledAfterTaint();
sink(*globalInt); // $ ir=576:17 MISSING: ast=576:17 SPURIOUS: ir=562:17 sink(*globalInt); // $ ir=562:17 ir=576:17 MISSING: ast=562:17 ast=576:17
} }
} }