hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Move to library

Browse Source
This commit is contained in:
Ed Minnix
2023-11-02 10:25:47 -04:00
parent 65d05bf3de
commit 8ed3f3c865
2 changed files with 42 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
java/ql/src/Security/CWE/CWE-078/ExecTaintedEnvironment.ql
View File

@@ -11,43 +11,10 @@
*/
import java
import semmle.code.java.dataflow.TaintTracking
import semmle.code.java.dataflow.DataFlow
import semmle.code.java.dataflow.FlowSources
import semmle.code.java.dataflow.ExternalFlow
import semmle.code.java.security.TaintedEnvironmentVariableQuery
import ExecTaintedEnvironmentFlow::PathGraph
class ExecMethod extends Method {
ExecMethod() {
this.hasName("exec") and
this.getDeclaringType().hasQualifiedName("java.lang", "Runtime")
}
}
module ProcessBuilderEnvironmentFlow implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) {
source.getType().(RefType).hasQualifiedName("java.lang", "ProcessBuilder")
}
predicate isSink(DataFlow::Node sink) {
exists(MethodAccess ma | ma.getQualifier() = sink.asExpr() |
ma.getMethod().hasName("environment")
)
}
}
module ExecTaintedEnvironmentConfig implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) { source instanceof ThreatModelFlowSource }
predicate isSink(DataFlow::Node sink) { sinkNode(sink, "environment-injection") }
}
module ExecTaintedEnvironmentFlow = TaintTracking::Global<ExecTaintedEnvironmentConfig>;
from Flow::PathNode source, Flow::PathNode sink, string label
where
ExecTaintedCommandFlow::flowPath(source.asPathNode1(), sink.asPathNode1()) and label = "argument"
or
ExecTaintedEnvironmentFlow::flowPath(source.asPathNode2(), sink.asPathNode2()) and
label = "environment"
select sink.getNode(), sink, source, "This command will be execute with a tainted $@.",
sink.getNode(), label
from ExecTaintedEnvironmentFlow::PathNode source, ExecTaintedEnvironmentFlow::PathNode sink
where ExecTaintedEnvironmentFlow::flowPath(source, sink)
select sink.getNode(), source, sink, "This command will be execute with a tainted $@.",
sink.getNode(), "environment variable"