From 8da9b9d3eaaefc0ebd641ae9dab8e054b0ce0ccc Mon Sep 17 00:00:00 2001 From: luchua-bc Date: Mon, 2 Nov 2020 10:53:46 +0000 Subject: [PATCH] Add documentation to new library method and use the singular form --- java/ql/src/semmle/code/java/frameworks/android/Intent.qll | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/java/ql/src/semmle/code/java/frameworks/android/Intent.qll b/java/ql/src/semmle/code/java/frameworks/android/Intent.qll index f9ede6f30e6..92c49f3101a 100644 --- a/java/ql/src/semmle/code/java/frameworks/android/Intent.qll +++ b/java/ql/src/semmle/code/java/frameworks/android/Intent.qll @@ -43,8 +43,9 @@ class IntentGetExtraMethod extends Method, TaintPreservingCallable { override predicate returnsTaintFrom(int arg) { arg = -1 } } -class BundleGetterMethods extends Method, TaintPreservingCallable { - BundleGetterMethods() { +/** A getter on `android.os.BaseBundle` or `android.os.Bundle`. */ +class BundleGetterMethod extends Method, TaintPreservingCallable { + BundleGetterMethod() { getDeclaringType().hasQualifiedName("android.os", ["BaseBundle", "Bundle"]) and getName().matches("get%") }