hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 09:13:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Exclude annotations from consistency check due to intentionally missing children

Browse Source
This commit is contained in:
Chris Smowton
2022-11-25 11:26:29 +00:00
parent 70ebb41d67
commit 8ca05d8fef
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/ql/consistency-queries/children.ql
View File

@@ -41,7 +41,12 @@ predicate gapInChildren(Element e, int i) {
// -1 can be skipped (type arguments from -2 down, no qualifier at -1, // -1 can be skipped (type arguments from -2 down, no qualifier at -1,
// then arguments from 0). // then arguments from 0).
// Can we also skip arguments, e.g. due to defaults for parameters? // Can we also skip arguments, e.g. due to defaults for parameters?
not (e instanceof MethodAccess and e.getFile().isKotlinSourceFile()) not (e instanceof MethodAccess and e.getFile().isKotlinSourceFile()) and
// Kotlin-extracted annotations can have missing children where a default
// value should be, because kotlinc doesn't load annotation defaults and we
// want to leave a space for another extractor to fill in the default if it
// is able.
not e instanceof Annotation
} }
predicate lateFirstChild(Element e, int i) { predicate lateFirstChild(Element e, int i) {
@@ -59,7 +64,12 @@ predicate lateFirstChild(Element e, int i) {
not (e instanceof LocalVariableDeclStmt and i = 1 and not exists(nthChildOf(e, 2))) and not (e instanceof LocalVariableDeclStmt and i = 1 and not exists(nthChildOf(e, 2))) and
// For statements may or may not declare a new variable (child 0), or // For statements may or may not declare a new variable (child 0), or
// have a condition (child 1). // have a condition (child 1).
not (e instanceof ForStmt and i = [1, 2]) not (e instanceof ForStmt and i = [1, 2]) and
// Kotlin-extracted annotations can have missing children where a default
// value should be, because kotlinc doesn't load annotation defaults and we
// want to leave a space for another extractor to fill in the default if it
// is able.
not e instanceof Annotation
} }
from Element e, int i, string problem from Element e, int i, string problem