hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make ZipSlip module classes private and push Sanitizer definition to ZipSlipCustomization.qll

Browse Source
This commit is contained in:
Grzegorz Niedziela
2023-02-17 12:49:04 +00:00
committed by GitHub
parent d8eafea719
commit 8bbbb95a87
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
ruby/ql/lib/codeql/ruby/security/ZipSlipCustomizations.qll
View File

@@ -38,7 +38,7 @@ module ZipSlip {
/**
* A call to `Zlib::GzipReader.open(path)`, considered a flow source.
*/
class GzipReaderOpen extends Source {
private class GzipReaderOpen extends Source {
GzipReaderOpen() {
this = API::getTopLevelMember("Zlib").getMember("GzipReader").getReturn("open").asSource() and
// If argument refers to a string object, then it's a hardcoded path and
@@ -54,7 +54,7 @@ module ZipSlip {
/**
* A call to `Gem::Package::TarReader.new(file_stream)`, considered a flow source.
*/
class TarReaderInstance extends Source {
private class TarReaderInstance extends Source {
TarReaderInstance() {
this =
API::getTopLevelMember("Gem")
@@ -75,7 +75,7 @@ module ZipSlip {
/**
* A call to `Zip::File.open(path)`, considered a flow source.
*/
class ZipFileOpen extends Source {
private class ZipFileOpen extends Source {
ZipFileOpen() {
this = API::getTopLevelMember("Zip").getMember("File").getReturn("open").asSource() and
// If argument refers to a string object, then it's a hardcoded path and
@@ -91,20 +91,20 @@ module ZipSlip {
/**
* A comparison with a constant string, considered as a sanitizer-guard.
*/
class StringConstCompareAsSanitizer extends Sanitizer, StringConstCompareBarrier { }
private class StringConstCompareAsSanitizer extends Sanitizer, StringConstCompareBarrier { }
/**
* An inclusion check against an array of constant strings, considered as a
* sanitizer-guard.
*/
class StringConstArrayInclusionCallAsSanitizer extends Sanitizer,
private class StringConstArrayInclusionCallAsSanitizer extends Sanitizer,
StringConstArrayInclusionCallBarrier { }
/**
* A sanitizer like `File.expand_path(path).start_with?` where `path` is a path of a single entry inside the archive.
* It is assumed that if `File.expand_path` is called, it is to verify the path is safe so there's no modelling of `start_with?` or other comparisons to avoid false-negatives.
* It is assumed that if `File.expand_path` is called, it is to verify the path is safe so there's no modeling of `start_with?` or other comparisons to avoid false-negatives.
*/
class ExpandedPathStartsWithAsSanitizer extends Sanitizer {
private class ExpandedPathStartsWithAsSanitizer extends Sanitizer {
ExpandedPathStartsWithAsSanitizer() {
exists(DataFlow::CallNode cn |
cn.getMethodName() = "expand_path" and
@@ -112,4 +112,10 @@ module ZipSlip {
)
}
}
/**
* Existing PathSanitization model created for regular path traversals
*/
private class PathSanitizationAsSanitizer extends Sanitizer instanceof Path::PathSanitization { }
}