hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Move upgrade script to the very end, add a few details.

Browse Source
This commit is contained in:
Geoffrey White
2025-09-11 09:44:10 +01:00
parent 9a96372f53
commit 8af8c6d95a
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
rust/README.md
View File

@@ -88,7 +88,7 @@ installing [`cargo-edit`](https://crates.io/crates/cargo-edit) with `cargo insta
``` ```
bazel run //rust/codegen bazel run //rust/codegen
``` ```
Take note whether `rust/schema/ast.py` was changed. That might need tweaks, new tests and/or downgrade/upgrade scripts down the line Take note whether `rust/schema/ast.py` was changed. That might need tweaks, new tests and/or downgrade/upgrade scripts down the line.
6. Try compiling 6. Try compiling
``` ```
bazel run //rust:install bazel run //rust:install
@@ -105,6 +105,8 @@ installing [`cargo-edit`](https://crates.io/crates/cargo-edit) with `cargo insta
If you had to do any changes, commit them. If you updated the rust toolchain, running `rust/lint.py` might reformat or apply new If you had to do any changes, commit them. If you updated the rust toolchain, running `rust/lint.py` might reformat or apply new
lints to the code. lints to the code.
7. If in step 5 the schema was updated, add upgrade/downgrade scripts and a change note 7. Check with CI if everything is in order.
8. Check with CI if everything is in order. 8. Run DCA. Iterate on the code if needed.
9. Run DCA. Iterate on the code if needed. 9. If in step 5 the schema was updated, add upgrade/downgrade scripts and a change note. This is best done last to reduce the chance of
merge conflicts (none of the other testing depends on having upgrade and downgrade scripts in place). See
[Upgrading a language database schema](docs/prepare-db-upgrade.md).