renamed "isOptionalMember" to "is_optional_member"

javascript/extractor/src/com/semmle/js/ast/DeclarationFlags.java

@@ -44,7 +44,7 @@ public class DeclarationFlags {
           "has_public_keyword",
           "has_private_keyword",
           "has_protected_keyword",
-          "isOptionalMember",
+          "is_optional_member",
           "hasDefiniteAssignmentAssertion",
           "has_declare_keyword");
 

javascript/extractor/tests/ts/output/trap/mappedTypeModifiers.ts.trap

@@ -1124,7 +1124,7 @@ enclosing_stmt(#20366,#20359)
 expr_containers(#20366,#20265)
 literals("a","a",#20366)
 is_abstract_member(#20364)
-isOptionalMember(#20364)
+is_optional_member(#20364)
 #20367=*
 typeexprs(#20367,2,#20364,2,"string")
 hasLocation(#20367,#20239)

javascript/ql/src/semmle/javascript/Aliases.qll

@@ -195,3 +195,8 @@ deprecated predicate hasReadonlyKeyword(Property prop) { has_readonly_keyword(pr
  * Use the `isTypeOnly` method on the `ImportDeclaration`/`ExportDeclaration` classes instead.
  */ 
 deprecated predicate hasTypeKeyword(ASTNode id) { has_type_keyword(id) }
+/**
+ * Alias for the predicate `is_optional_member` defined in the .dbscheme.
+ * Use `FieldDeclaration#isOptional()` instead.
+ */ 
+deprecated predicate isOptionalMember(Property id) { is_optional_member(id) }

javascript/ql/src/semmle/javascript/Classes.qll

@@ -1043,7 +1043,7 @@ class FieldDeclaration extends MemberDeclaration, @field {
   predicate isReadonly() { has_readonly_keyword(this) }
 
   /** Holds if this is a TypeScript field marked as optional with the `?` operator. */
-  predicate isOptional() { isOptionalMember(this) }
+  predicate isOptional() { is_optional_member(this) }
 
   /** Holds if this is a TypeScript field marked as definitely assigned with the `!` operator. */
   predicate hasDefiniteAssignmentAssertion() { hasDefiniteAssignmentAssertion(this) }

javascript/ql/src/semmlecode.javascript.dbscheme

@@ -525,7 +525,7 @@ has_private_keyword (int id: @property ref);
 has_protected_keyword (int id: @property ref);
 has_readonly_keyword (int id: @property ref);
 has_type_keyword (int id: @import_or_export_declaration ref);
-isOptionalMember (int id: @property ref);
+is_optional_member (int id: @property ref);
 hasDefiniteAssignmentAssertion (int id: @field_or_vardeclarator ref);
 isOptionalParameterDeclaration (unique int parameter: @pattern ref);
 

javascript/ql/src/semmlecode.javascript.dbscheme.stats

@@ -8007,7 +8007,7 @@
 <dependencies/>
 </relation>
 <relation>
-<name>isOptionalMember</name>
+<name>is_optional_member</name>
 <cardinality>3668</cardinality>
 <columnsizes>
 <e>

javascript/upgrades/c73fbfca57f3d593b9ff50c6aa3a886d6888efec/upgrade.properties

@@ -52,3 +52,5 @@ has_readonly_keyword.rel: reorder hasReadonlyKeyword.rel(int prop) prop
 hasReadonlyKeyword.rel: delete
 has_type_keyword.rel: reorder hasTypeKeyword.rel(int id) id
 hasTypeKeyword.rel: delete
+is_optional_member.rel: reorder isOptionalMember.rel(int id) id
+isOptionalMember.rel: delete