hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Rename RouteHandlerInput->RouteHandlerParameter

Browse Source
This commit is contained in:
Asger Feldthaus
2021-12-15 16:32:18 +01:00
parent 218b746f6f
commit 8aa4d8227e
3 changed files with 19 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/Security/CWE-352/MissingCsrfMiddleware.ql
View File

@@ -21,7 +21,7 @@ string cookieProperty() { result = "session" or result = "cookies" or result = "
*/
predicate isRouteHandlerUsingCookies(Routing::RouteHandler handler) {
exists(DataFlow::PropRef value |
value = handler.getAnInput().ref().getAPropertyRead(cookieProperty()).getAPropertyReference() and
value = handler.getAParameter().ref().getAPropertyRead(cookieProperty()).getAPropertyReference() and
// Ignore accesses to values that are part of a CSRF or captcha check
not value.getPropertyName().regexpMatch("(?i).*(csrf|xsrf|captcha).*") and
// Ignore calls like `req.session.save()`
@@ -124,7 +124,7 @@ private Routing::RouteHandler getAHandlerSettingCsrfCookie() {
* Or by the response parameter setting a CSRF related cookie.
*/
predicate isCsrfProtectionRouteHandler(Routing::RouteHandler handler) {
handler.getAnInput() = nodeLeadingToCsrfWriteOrCheck(DataFlow::TypeBackTracker::end())
handler.getAParameter() = nodeLeadingToCsrfWriteOrCheck(DataFlow::TypeBackTracker::end())
or
handler = getAHandlerSettingCsrfCookie()
}