hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply code review suggestions

Browse Source
This commit is contained in:
Tony Torralba
2022-04-19 17:23:04 +02:00
parent 6f7b7c9efe
commit 8a3ed6bdcf
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/ql/src/utils/stub-generator/Stubs.qll
View File

@@ -414,16 +414,15 @@ private string stubAnnotation(Annotation a) {
private string stubAnnotationSimpleValue(Expr value) {
result = value.(FieldAccess).getField().getQualifiedName()
or
result = value.(Literal).getLiteral()
or
not value instanceof Literal and
(
result = value.(CompileTimeConstantExpr).getStringValue() or
result = value.(CompileTimeConstantExpr).getBooleanValue().toString() or
result = value.(CompileTimeConstantExpr).getIntValue().toString()
)
value instanceof Literal or
value instanceof CompileTimeConstantExpr
) and
result = stubDefaultValue(value.getType())
or
result = value.(Annotation).getType().getName()
// We can't use stubAnnotation here because it causes a non-monotonic recursion.
// Handling the most basic case of a nested annotation for now.
result = "@" + value.(Annotation).getType().getName()
or
result = value.(TypeLiteral).getReferencedType().getName() + ".class"
}
@@ -435,6 +434,7 @@ private string stubAnnotationValue(Expr value) {
result =
"{" +
concat(int i, Expr arrayElement |
i >= 0 and
arrayElement = value.(ArrayInit).getInit(i)
|
stubAnnotationSimpleValue(arrayElement), "," order by i